Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept PS4 and PS5 values for ActivityPlatform type. #7803

Closed
Viriatto opened this issue Apr 16, 2022 · 4 comments · Fixed by #7805
Closed

Accept PS4 and PS5 values for ActivityPlatform type. #7803

Viriatto opened this issue Apr 16, 2022 · 4 comments · Fixed by #7805

Comments

@Viriatto
Copy link

Which package is this bug report for?

discord.js

Issue description

Activity objects have been registered with a value of PS4 and PS5 for their platform property, whose type currently only accepts xbox, desktop or samsung.

Code sample

No response

Package version

13.6.0

Node.js version

16.6.2

Operating system

No response

Priority this issue should have

Low (slightly annoying)

Which partials do you have configured?

Not applicable (subpackage bug)

Which gateway intents are you subscribing to?

Not applicable (subpackage bug)

I have tested this issue on a development release

No response

@Jiralite
Copy link
Member

Hmm. intense thinking

It seems these types were added with #4984. However, the upstream pull request does not document these types. I currently cannot find the types with the current documentation, either.

Perhaps we should just allow a string and not some predetermined types?

@ImRodry
Copy link
Contributor

ImRodry commented Apr 16, 2022

The types were on the upstream PR but were removed before merge so I'm guessing these shouldn't even be on discord.js: discord/discord-api-docs@5822b0b (#2219)

@Viriatto
Copy link
Author

Hmm. intense thinking

It seems these types were added with #4984. However, the upstream pull request does not document these types. I currently cannot find the types with the current documentation, either.

Perhaps we should just allow a string and not some predetermined types?

Current documentation for ActivityPlatform type is here: https://discord.js.org/#/docs/discord.js/stable/typedef/ActivityPlatform

@ImRodry
Copy link
Contributor

ImRodry commented Apr 16, 2022

That's discord.js documentation, not Discord documentation

@kyranet kyranet added has PR and removed need repro labels Apr 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants