fix(Activity): platform type #7805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
|
Well this is slightly annoying... in -types we have https://github.com/discordjs/discord-api-types/blob/main/payloads/v10/gateway.ts#L211 but if it's not gonna be documented properly, might have to make it a string there too... 😕 to be seen, but approving here as it makes most sense |
vladfrangu
approved these changes
Apr 19, 2022
iCrawl
approved these changes
Apr 21, 2022
kyranet
approved these changes
Apr 21, 2022
SpaceEEC
approved these changes
Apr 21, 2022
Jiralite
added a commit
to suneettipirneni/guide
that referenced
this pull request
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Fix #7803
I deleted the
ActivityPlatformtype and addedstring. But if discord doesn't want to documentid,sync_id,platformand evensession_idas stated in discord/discord-api-docs@5822b0b shouldn't we delete them?Status and versioning classification: