Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for nsfw commands #7976

Merged
merged 4 commits into from Dec 16, 2022

Conversation

suneettipirneni
Copy link
Member

@suneettipirneni suneettipirneni commented May 28, 2022

Please describe the changes this PR makes and why it should be merged:

Adds support for nsfw commands.

Depends on:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Nov 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 2:06AM (UTC)
discord-js-guide ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 2:06AM (UTC)

@suneettipirneni suneettipirneni marked this pull request as ready for review November 9, 2022 23:34
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #7976 (8a1dc88) into main (6acf759) will increase coverage by 1.11%.
The diff coverage is 68.18%.

❗ Current head 8a1dc88 differs from pull request most recent head 928d187. Consider uploading reports for the commit 928d187 to get more accurate results

@@            Coverage Diff             @@
##             main    #7976      +/-   ##
==========================================
+ Coverage   84.45%   85.57%   +1.11%     
==========================================
  Files          95       96       +1     
  Lines        9149     9481     +332     
  Branches     1095     1134      +39     
==========================================
+ Hits         7727     8113     +386     
+ Misses       1380     1326      -54     
  Partials       42       42              
Flag Coverage Δ
brokers 65.24% <ø> (ø)
builders 98.45% <68.18%> (+<0.01%) ⬆️
collection 100.00% <ø> (ø)
proxy 81.53% <ø> (ø)
rest 91.97% <ø> (ø)
util 100.00% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.70% <ø> (ø)
ws 59.83% <ø> (+1.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lders/src/interactions/slashCommands/Assertions.ts 98.00% <50.00%> (-2.00%) ⬇️
.../interactions/slashCommands/SlashCommandBuilder.ts 97.72% <72.22%> (-2.28%) ⬇️
...trategies/context/SimpleContextFetchingStrategy.ts 71.42% <0.00%> (-12.79%) ⬇️
packages/ws/src/utils/constants.ts 83.87% <0.00%> (-1.85%) ⬇️
packages/collection/src/collection.ts 100.00% <0.00%> (ø)
packages/ws/src/utils/IdentifyThrottler.ts 100.00% <0.00%> (ø)
packages/ws/src/strategies/sharding/worker.ts 0.00% <0.00%> (ø)
...src/strategies/context/IContextFetchingStrategy.ts 100.00% <0.00%> (ø)
packages/builders/src/messages/formatters.ts 100.00% <0.00%> (ø)
.../src/strategies/sharding/SimpleShardingStrategy.ts 78.20% <0.00%> (+0.12%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jiralite Jiralite removed the blocked label Dec 16, 2022
@kodiakhq kodiakhq bot merged commit 7a51344 into discordjs:main Dec 16, 2022
xHyroM added a commit to Garlic-Team/gcommands that referenced this pull request Dec 18, 2022
**Please describe the changes this PR makes and why it should be
merged:**
waiting for official release - X
djs - discordjs/discord.js#7976

**Status and versioning classification:**
- This PR changes the library's interface (methods or parameters added)

<!--
Please move lines that apply to you out of the comment:
- This PR includes breaking changes (methods removed or renamed,
parameters moved or removed)
- This PR **only** includes non-code changes, like changes to
documentation, README, etc.
-->
@suneettipirneni suneettipirneni deleted the feat/nsfw-commands branch January 10, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants