fix(ClientOptions): make ClientOptions#intents returns an IntentsBitField

[Idris1401]

Please describe the changes this PR makes and why it should be merged:

I think it's better that ClientOptions#intents returns an instance of IntentsBitField instead of just a number.

Status and versioning classification:

• Code changes have been tested against the Discord API, or there are no code changes
• I know how to update typings and have done so, or typings don't need updating

[almeidx]

discord.js/packages/discord.js/src/client/websocket/WebSocketShard.js

Line 690 in 7a9e52e

intents: IntentsBitField.resolve(client.options.intents),

intents: client.options.intents.bitfield,

---

discord.js/packages/discord.js/src/client/websocket/WebSocketShard.js

Line 515 in 7a9e52e

const hasGuildsIntent = new IntentsBitField(this.manager.client.options.intents).has(GatewayIntentBits.Guilds);

const hasGuildsIntent = this.manager.client.options.intents.has(GatewayIntentBits.Guilds);

[Jiralite]

If this is to be standardised, I guess the type when being accessed could be Omit<ClientOptions, "intents"> & { intents: IntentsBitField };?

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
discord-js	✅ Ready (Inspect)	Visit Preview	Oct 9, 2022 at 8:02PM (UTC)
discord-js-guide	✅ Ready (Inspect)	Visit Preview	Oct 9, 2022 at 8:02PM (UTC)

[Idris1401]

If this is to be standardised, I guess the type when being accessed could be Omit<ClientOptions, "intents"> & { intents: IntentsBitField };?

instead of BitFieldResolvable<GatewayIntentsString, number> (at line 4269 of index.d.ts) ?

[almeidx]

No, here

discord.js/packages/discord.js/typings/index.d.ts

Line 757 in 7a9e52e

public options: ClientOptions;

[Jiralite]

Please double-check the tests!

[Jiralite]

Would this need changing too?

discord.js/packages/discord.js/src/client/websocket/WebSocketShard.js

Line 695 in abb7226

this.debug(`[IDENTIFY] Shard ${this.id}/${client.options.shardCount} with intents: ${d.intents}`);

Previously, this emitted the bit field. However, it now emits the class (IntentsBitField { bitfield: 8192 } for example). It doesn't seem problematic either way.

[Idris1401]

Would this need changing too?

discord.js/packages/discord.js/src/client/websocket/WebSocketShard.js

Line 695 in abb7226

this.debug(`[IDENTIFY] Shard ${this.id}/${client.options.shardCount} with intents: ${d.intents}`);

Previously, this emitted the bit field. However, it now emits the class (IntentsBitField { bitfield: 8192 } for example). It doesn't seem problematic either way.

so no need to change it? ._.