fix: return only boolean for disabled
#8965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
|
this is probably gonna get a semver:major label but I really wish it didn't lol |
|
Not semver:major for the same reason as #8617: it's a valid return type, we're just narrowing the possibilities. |
iCrawl
approved these changes
Dec 23, 2022
|
Thought it would be major because we’re removing a possible return type but if you say it’s not then amazing! |
|
To sum things up a little, the old return type is |
kyranet
approved these changes
Dec 23, 2022
vladfrangu
approved these changes
Dec 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR changes
BaseSelectMenuComponent#disabledandButtonComponent#disabledto only return booleans.Fixes #8964
Status and versioning classification: