Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix malformed overridden documentation #8954

Merged

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Moving the JSDoc for these methods up properly shows them in the documentation... somehow. Currently, they do not work.

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Dec 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated
discord-js ⬜️ Ignored (Inspect) Dec 24, 2022 at 7:32AM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Dec 24, 2022 at 7:32AM (UTC)

@almeidx
Copy link
Member

almeidx commented Dec 19, 2022

Can you move this one too?

/**
* Sets the category parent of this channel.
* <warn>It is not currently possible to set the parent of a CategoryChannel.</warn>
* @method setParent
* @memberof CategoryChannel
* @instance
* @param {?CategoryChannelResolvable} channel The channel to set as parent
* @param {SetParentOptions} [options={}] The options for setting the parent
* @returns {Promise<GuildChannel>}
*/

@Jiralite Jiralite changed the title docs(AutoModerationRuleManager): Change placement of resolve() & resolveId() docs: Fix malformed overridden documentation Dec 19, 2022
@Jiralite
Copy link
Member Author

Done with 06381d4!

Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old as time

@kodiakhq kodiakhq bot merged commit 0b8b114 into discordjs:main Dec 24, 2022
@Jiralite Jiralite deleted the docs/auto-moderation-resolve-placement branch December 24, 2022 12:57
@kyranet kyranet mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants