Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: backport automod #8886

Merged
merged 13 commits into from
Jan 13, 2023
Merged

feat: backport automod #8886

merged 13 commits into from
Jan 13, 2023

Conversation

jaw0r3k
Copy link
Contributor

@jaw0r3k jaw0r3k commented Nov 30, 2022 •
edited by kyranet

Please describe the changes this PR makes and why it should be merged:

Backports #7938
Backports #8954
Backports #8962
Backports #8977

API types are added to rawTypes file

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Nov 30, 2022

@jaw0r3k is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Nov 30, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
discord-js ❌ Failed (Inspect) Jan 11, 2023 at 3:54PM (UTC)

Syjalo
Syjalo suggested changes Nov 30, 2022
View reviewed changes
src/util/Constants.js Show resolved Hide resolved
typings/index.d.ts Show resolved Hide resolved
almeidx
almeidx requested changes Nov 30, 2022
View reviewed changes
src/managers/AutoModerationRuleManager.js Outdated Show resolved Hide resolved
src/structures/AutoModerationRule.js Outdated Show resolved Hide resolved
@kyranet kyranet changed the title feat v13: backboard automod feat v13: backport automod Dec 20, 2022
kyranet
kyranet requested changes Dec 25, 2022
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

src/managers/AutoModerationRuleManager.js Outdated Show resolved Hide resolved
src/managers/AutoModerationRuleManager.js Outdated Show resolved Hide resolved
src/structures/AutoModerationActionExecution.js Outdated Show resolved Hide resolved
src/structures/AutoModerationRule.js Outdated Show resolved Hide resolved
src/structures/AutoModerationRule.js Show resolved Hide resolved
src/structures/AutoModerationRule.js Show resolved Hide resolved
src/structures/AutoModerationRule.js Show resolved Hide resolved
src/structures/AutoModerationRule.js Show resolved Hide resolved
src/structures/AutoModerationRule.js Show resolved Hide resolved
@kyranet kyranet added this to the discord.js v13.13 milestone Dec 26, 2022
@jaw0r3k @kyranet
Apply suggestions from code review
034afba 
Co-authored-by: Aura Román <kyradiscord@gmail.com>
Jiralite
Jiralite requested changes Dec 26, 2022
View reviewed changes
Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changes from:

kyranet
kyranet requested changes Dec 26, 2022
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed a couple of backports, thanks @Jiralite for reporting them internally!

src/managers/AutoModerationRuleManager.js Outdated Show resolved Hide resolved
src/structures/AutoModerationRule.js Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
Jiralite
Jiralite requested changes Dec 26, 2022
View reviewed changes
src/util/Constants.js Outdated Show resolved Hide resolved
@jaw0r3k @kyranet
Apply suggestions from code review
e525c86 
Co-authored-by: Aura Román <kyradiscord@gmail.com>
kyranet
kyranet requested changes Dec 26, 2022
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing

src/managers/AutoModerationRuleManager.js Outdated Show resolved Hide resolved
@jaw0r3k @kyranet
Update src/managers/AutoModerationRuleManager.js
1b71aca 
Co-authored-by: Aura Román <kyradiscord@gmail.com>
@iCrawl iCrawl requested a review from vladfrangu January 2, 2023 15:23
Jiralite
Jiralite requested changes Jan 9, 2023
View reviewed changes
Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MessageTypes is missing AUTO_MODERATION_ACTION.

Jiralite
Jiralite requested changes Jan 11, 2023
View reviewed changes
Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also missing the AUTO_MODERATION guild feature.

@iCrawl iCrawl changed the title feat v13: backport automod feat: backport automod Jan 13, 2023
@iCrawl iCrawl merged commit 4287983 into discordjs:v13 Jan 13, 2023
@jaw0r3k jaw0r3k deleted the v13-automod branch March 16, 2023 18:56
@Jiralite Jiralite mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiralite Jiralite Jiralite requested changes

@almeidx almeidx almeidx requested changes

@Syjalo Syjalo Syjalo requested changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
api support backport packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js 13.13.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jaw0r3k @vladfrangu @iCrawl @kyranet @SpaceEEC @Jiralite @almeidx @Syjalo