Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModalSubmitInteraction's types have deferUpdate #8958

Closed
ImRodry opened this issue Dec 21, 2022 · 5 comments
Closed

ModalSubmitInteraction's types have deferUpdate #8958

ImRodry opened this issue Dec 21, 2022 · 5 comments

Comments

@ImRodry
Copy link
Contributor

ImRodry commented Dec 21, 2022

Which package is this bug report for?

discord.js

Issue description

The types for the ModalSubmitInteraction class have the deferUpdate method but not update. I believe it shouldn't have either as these methods should be exclusive to the ModalMessageModalSubmitInteraction class

Code sample

No response

Package version

14.7.1

Node.js version

18.12.1

Operating system

Windows 11

Priority this issue should have

Low (slightly annoying)

Which partials do you have configured?

Not applicable (subpackage bug)

Which gateway intents are you subscribing to?

Not applicable (subpackage bug)

I have tested this issue on a development release

No response

@MrMythicalYT
Copy link
Contributor

#8455 says it's possible to .deferUpdate() even if it isn't from a message

@monbrey
Copy link
Member

monbrey commented Dec 21, 2022

At the time I made that PR, that was correct.

Has this been retested and is no longer the case?

@Jiralite
Copy link
Member

I just tested and I was able to use deferUpdate() on a ModalSubmitInteraction without error. This seems fine?

@ImRodry
Copy link
Contributor Author

ImRodry commented Dec 21, 2022

I didn't test it but it didn't seem very logical, what happens when you deferUpdate an interaction that isn't from a message?

@Jiralite
Copy link
Member

Jiralite commented Dec 21, 2022

Discord accepts it and there seems to be no visible resulting message. Looks like a way to ignore a modal's submission.

@Jiralite Jiralite closed this as not planned Won't fix, can't repro, duplicate, stale Dec 21, 2022
@Jiralite Jiralite added invalid and removed bug labels Dec 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants