Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: deferUpdate is only allowed in Message Modals #9910

Conversation

ImRodry
Copy link
Contributor

@ImRodry ImRodry commented Oct 24, 2023

Please describe the changes this PR makes and why it should be merged:

This PR moves the deferUpdate typings from the ModalSubmitInteraction to the ModalMessageModalSubmitInteraction since running this function in the aforementioned class results in an Unknown Message error, despite the function actually being defined.
Fixes #8958

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@ImRodry ImRodry requested a review from a team as a code owner October 24, 2023 17:30
@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2023 5:30pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2023 5:30pm

@github-actions
Copy link

Running Lighthouse audit...

@ImRodry
Copy link
Contributor Author

ImRodry commented Oct 24, 2023

Nvm the error comes from running editReply after deferring, not the actual defer

@ImRodry ImRodry closed this Oct 24, 2023
@ImRodry ImRodry deleted the types/deferUpdate-only-on-message-modals branch October 24, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModalSubmitInteraction's types have deferUpdate
1 participant