Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deno compat #10271

Merged
merged 3 commits into from
May 13, 2024
Merged

fix: deno compat #10271

merged 3 commits into from
May 13, 2024

Conversation

didinele
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
See https://canary.discord.com/channels/222078108977594368/1237471430887604375/1239037602699546645

@didinele didinele requested a review from a team as a code owner May 12, 2024 12:48
Copy link

vercel bot commented May 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 0:00am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 0:00am

@Erisfiregamer1
Copy link

Erisfiregamer1 commented May 12, 2024

As the person who actively looked into this: Yeah, this is good.

Tested and it works on my project

@Jiralite Jiralite added this to the ws 1.2.0 milestone May 13, 2024
@Jiralite Jiralite modified the milestones: ws 1.2.0, ws 2.0.0 May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 19.38%. Comparing base (3640fe7) to head (b120bca).

Files Patch % Lines
packages/ws/src/ws/WebSocketShard.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main   #10271       +/-   ##
============================================
- Coverage   100.00%   19.38%   -80.62%     
============================================
  Files            1       32       +31     
  Lines           18     6264     +6246     
  Branches         4       77       +73     
============================================
+ Hits            18     1214     +1196     
- Misses           0     5050     +5050     
Flag Coverage Δ
brokers 19.14% <0.00%> (-80.86%) ⬇️
builders 19.14% <0.00%> (-80.86%) ⬇️
guide 19.14% <0.00%> (-80.86%) ⬇️
website 19.14% <0.00%> (-80.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 616208b into main May 13, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/deno-ws-compat branch May 13, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants