Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Rest): better handling of global rate limit and invalid request tracking #4711

Merged
merged 8 commits into from
Mar 31, 2021
Merged

feat(Rest): better handling of global rate limit and invalid request tracking #4711

merged 8 commits into from
Mar 31, 2021

Commits on Feb 18, 2021

  1. feat(Rest): support pre-emptive enforcement of the global rate limit 

    Add customizable restGlobalRateLimit to pre-emptively monitor global rate limit
Report the real tiemout when the global rate limit is hit
Handle rate sublimits for individual requests
Remove unnecessary double wait from some rate limit handling code paths
    @ahnolds
    ahnolds committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    6c2a923 View commit details
    Browse the repository at this point in the history

  2. feat(InvalidRequests): warn if there are too many invalid rest requests 

    Emit a warning periodically as the the number of invalid (401, 403,
429) rest requests increases to allow clients to avoid the 10k invalid
requests in 10 minutes temporary ban
    @ahnolds
    ahnolds committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    90a2386 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Declare variables with let rather than var (in a previous version these variables had been used outside of block scope).

Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
    @ahnolds @NotSugden
    ahnolds and NotSugden committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    36a28cf View commit details
    Browse the repository at this point in the history

  4. Attach the timeout to the client. 

    Co-authored-by: Tristan Guichaoua <33934311+tguichaoua@users.noreply.github.com>
    @ahnolds @tguichaoua
    ahnolds and tguichaoua committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    97165be View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Avoid colliding with the global `global`

Co-authored-by: Papaia <43409674+Papaia@users.noreply.github.com>
    @ahnolds @papaia
    ahnolds and papaia committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    1de446b View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review

    @ahnolds
    ahnolds committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    e5a6a3b View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
    @ahnolds @NotSugden @vladfrangu
    3 people committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    cbe0cb0 View commit details
    Browse the repository at this point in the history

  2. Avoid mutating the REST result object

    @ahnolds
    ahnolds committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    e1aec15 View commit details
    Browse the repository at this point in the history