Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Message): reply method; #5567

Closed
wants to merge 1 commit into from
Closed

fix(Message): reply method; #5567

wants to merge 1 commit into from

Conversation

birongliu
Copy link

Please describe the changes this PR makes and why it should be merged:
this PR will check if there is a replyTo option exist in reply method; if there is, it would reply to message according to replyTo property pass into the reply method by end user if not it would default to current message (this).

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes

@monbrey
Copy link
Member

monbrey commented Apr 28, 2021

I don't think this is the direction we want to take on this. It's been discussed internally by the maintainers, and I think the agreement was that Message#reply should not accept replyTo at all.

TextChannel#send is where the replyTo option can be used correctly.

Edit: It's already been done #5296

@iCrawl iCrawl closed this Apr 30, 2021
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants