Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Types): make event listeners accept async callbacks #5602

Merged
merged 4 commits into from May 29, 2021
Merged

fix(Types): make event listeners accept async callbacks #5602

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15bce60
fix(Types): make event listeners accept unknown-returned cb
kyranet May 9, 2021
5f4a339
fix(Types): use `void | Promise<void>` over `unknown`
kyranet May 9, 2021
b254be9
revert: fix 5f4a339
kyranet May 9, 2021
8c84043
fix(Types): use Awaited<T>
kyranet May 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions typings/index.d.ts
View file
Open in desktop
Expand Up @@ -311,25 +311,25 @@ declare module 'discord.js' {
public sweepMessages(lifetime?: number): number;
public toJSON(): object;

public on<K extends keyof ClientEvents>(event: K, listener: (...args: ClientEvents[K]) => void): this;
public on<K extends keyof ClientEvents>(event: K, listener: (...args: ClientEvents[K]) => unknown): this;
public on<S extends string | symbol>(
event: Exclude<S, keyof ClientEvents>,
listener: (...args: any[]) => void,
listener: (...args: any[]) => unknown,
): this;

public once<K extends keyof ClientEvents>(event: K, listener: (...args: ClientEvents[K]) => void): this;
public once<K extends keyof ClientEvents>(event: K, listener: (...args: ClientEvents[K]) => unknown): this;
public once<S extends string | symbol>(
event: Exclude<S, keyof ClientEvents>,
listener: (...args: any[]) => void,
listener: (...args: any[]) => unknown,
): this;

public emit<K extends keyof ClientEvents>(event: K, ...args: ClientEvents[K]): boolean;
public emit<S extends string | symbol>(event: Exclude<S, keyof ClientEvents>, ...args: any[]): boolean;

public off<K extends keyof ClientEvents>(event: K, listener: (...args: ClientEvents[K]) => void): this;
public off<K extends keyof ClientEvents>(event: K, listener: (...args: ClientEvents[K]) => unknown): this;
public off<S extends string | symbol>(
event: Exclude<S, keyof ClientEvents>,
listener: (...args: any[]) => void,
listener: (...args: any[]) => unknown,
): this;

public removeAllListeners<K extends keyof ClientEvents>(event?: K): this;
Expand Down