Better error handling #5665
Closed
Better error handling #5665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The typings need to be updated as well. |
SpaceEEC
requested changes
May 26, 2021
| @@ -139,6 +146,7 @@ class CommandInteraction extends Interaction { | |||
| * .catch(console.error); | |||
| */ | |||
| async fetchReply() { | |||
| if (this.ephemeral) throw new Error('Unable to fetch ephemeral response'); | |||
There was a problem hiding this comment.
The current error surely does not look right 😄
Error: An invalid error message key was used: Unable to fetch ephemeral response.You need to register your error in this object here
discord.js/src/errors/Messages.js
Line 115 in 3a8ba57
Maybe
INTERACTION_EHPEMERAL_REPLIED?
| * Whether the reply to this interaction is ephemeral | ||
| * @type {boolean} | ||
| */ | ||
| this.ephemeral = false; |
There was a problem hiding this comment.
Maybe initialize it with null since the interaction wasn't replied to yet?
|
This PR has conflicting files, please rebase it on top of fixing the requested changes above? |
|
Superseeded by #5892 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
I've added the property
ephemeralto theCommandInteractionclass.This is useful for throwing an error while fetching an ephemeral response.
Status and versioning classification: