Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Typings): add missing typings for HttpError -> requestData #5742

Merged
merged 9 commits into from Jun 3, 2021
3 changes: 2 additions & 1 deletion src/rest/HTTPError.js
Expand Up @@ -42,8 +42,9 @@ class HTTPError extends Error {
/**
* The attachment data that is sent to Discord
* @typedef {Object} HTTPAttachmentData
* @property {string|Buffer|Stream} attachment The source of this attachment data
* @property {string} name The file name
* @property {Buffer} file The file buffer
* @property {Buffer|Stream} file The file buffer
*/

/**
Expand Down
17 changes: 15 additions & 2 deletions typings/index.d.ts
Expand Up @@ -703,13 +703,14 @@ declare module 'discord.js' {
}

export class DiscordAPIError extends Error {
constructor(path: string, error: unknown, method: string, httpStatus: number);
constructor(error: unknown, status: number, request: unknown);
private static flattenErrors(obj: unknown, key: string): string[];

public code: number;
public method: string;
public path: string;
public httpStatus: number;
public requestData: HTTPErrorData;
}

export class DMChannel extends TextBasedChannel(Channel, ['bulkDelete']) {
Expand Down Expand Up @@ -1045,11 +1046,12 @@ declare module 'discord.js' {
}

export class HTTPError extends Error {
constructor(message: string, name: string, code: number, method: string, path: string);
constructor(message: string, name: string, code: number, request: unknown);
public code: number;
public method: string;
public name: string;
public path: string;
public requestData: HTTPErrorData;
}

export class Integration extends Base {
Expand Down Expand Up @@ -3083,6 +3085,17 @@ declare module 'discord.js' {
cache?: boolean;
}

interface HTTPAttachmentData {
attachment: string | Buffer | Stream;
name: string;
casperiv0 marked this conversation as resolved.
Show resolved Hide resolved
file: Buffer | Stream;
}

interface HTTPErrorData {
json: unknown;
files: HTTPAttachmentData[];
}

interface HTTPOptions {
api?: string;
version?: number;
Expand Down