Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: enforce single param on sending/editing methods #5758

Merged
merged 35 commits into from
Jun 9, 2021
Merged

refactor: enforce single param on sending/editing methods #5758

merged 35 commits into from
Jun 9, 2021

Commits on Jun 6, 2021

  1. refactor(InteractionResponses): only take one input param

    @castdrian
    castdrian committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    58bcfee View commit details
    Browse the repository at this point in the history

  2. fix(Typings): shouldn't be null

    @castdrian
    castdrian committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    4a7e5e6 View commit details
    Browse the repository at this point in the history

  3. refactor(TextBasedChannel): only take one input param

    @castdrian
    castdrian committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    3bfa03a View commit details
    Browse the repository at this point in the history

  4. fix(*): remove unecessary param

    @castdrian
    castdrian committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    178f5be View commit details
    Browse the repository at this point in the history

  5. refactor(Message): only take one param

    @castdrian
    castdrian committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    34dedac View commit details
    Browse the repository at this point in the history

  6. refactor(Webhook): only take one param

    @castdrian
    castdrian committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    572daae View commit details
    Browse the repository at this point in the history

  7. fix(Typings): remove unnecessary overload

    @castdrian
    castdrian committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    8071d8a View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2021

  1. apply code suggestion 

    Co-authored-by: ckohen <chaikohen@gmail.com>
    @castdrian @ckohen
    castdrian and ckohen committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    78d1c36 View commit details
    Browse the repository at this point in the history

  2. refactor(*): remove unnecessary statements

    @castdrian
    castdrian committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    3b3a234 View commit details
    Browse the repository at this point in the history

  3. refactor(ApiMessage): only accept content or options

    @castdrian
    castdrian committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    39a30e3 View commit details
    Browse the repository at this point in the history

  4. fix(Message): fix reply

    @castdrian
    castdrian committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    cc47061 View commit details
    Browse the repository at this point in the history

  5. refactor(Typings): remove MessageAdditions and update method params

    @castdrian
    castdrian committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    2503657 View commit details
    Browse the repository at this point in the history

  6. fix(Typings): fix index.ts

    @castdrian
    castdrian committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    a7de98d View commit details
    Browse the repository at this point in the history

  7. fix(JsDoc): remove MessageAdditions

    @castdrian
    castdrian committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    4b90dbd View commit details
    Browse the repository at this point in the history

  8. fix(InteractionResponses): proper arg order when creating apimessage

    @castdrian
    castdrian committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    4be1f86 View commit details
    Browse the repository at this point in the history

  9. Update src/structures/Message.js 

    Co-authored-by: Jan <66554238+vaporox@users.noreply.github.com>
    @castdrian @vaporoxx
    castdrian and vaporoxx committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    df49410 View commit details
    Browse the repository at this point in the history

  10. Update src/structures/Webhook.js 

    Co-authored-by: Jan <66554238+vaporox@users.noreply.github.com>
    @castdrian @vaporoxx
    castdrian and vaporoxx committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    c790a52 View commit details
    Browse the repository at this point in the history

  11. Update src/structures/interfaces/InteractionResponses.js 

    Co-authored-by: Jan <66554238+vaporox@users.noreply.github.com>
    @castdrian @vaporoxx
    castdrian and vaporoxx committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    f27654d View commit details
    Browse the repository at this point in the history

  12. Update src/structures/interfaces/InteractionResponses.js 

    Co-authored-by: Jan <66554238+vaporox@users.noreply.github.com>
    @castdrian @vaporoxx
    castdrian and vaporoxx committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    ad1c43b View commit details
    Browse the repository at this point in the history

  13. Update src/structures/interfaces/InteractionResponses.js 

    Co-authored-by: Jan <66554238+vaporox@users.noreply.github.com>
    @castdrian @vaporoxx
    castdrian and vaporoxx committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    3806379 View commit details
    Browse the repository at this point in the history

  14. Update typings/index.ts 

    Co-authored-by: Jan <66554238+vaporox@users.noreply.github.com>
    @castdrian @vaporoxx
    castdrian and vaporoxx committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    812252e View commit details
    Browse the repository at this point in the history

  15. fix(Message): fix JSDoc

    @castdrian
    castdrian committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    932080c View commit details
    Browse the repository at this point in the history

  16. fix(Typings): remove unnecessary overloads

    @castdrian
    castdrian committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    ab52bf8 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. apply code suggestion 

    Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
    @castdrian @SpaceEEC
    castdrian and SpaceEEC committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    7cd765f View commit details
    Browse the repository at this point in the history

  2. apply code suggestion 

    Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
    @castdrian @SpaceEEC
    castdrian and SpaceEEC committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    c8ebc24 View commit details
    Browse the repository at this point in the history

  3. apply code suggestion 

    Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
    @castdrian @SpaceEEC
    castdrian and SpaceEEC committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    77eb1a0 View commit details
    Browse the repository at this point in the history

  4. apply code suggestion 

    Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
    @castdrian @SpaceEEC
    castdrian and SpaceEEC committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    54378ee View commit details
    Browse the repository at this point in the history

  5. apply code suggestion 

    Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
    @castdrian @SpaceEEC
    castdrian and SpaceEEC committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    ca02421 View commit details
    Browse the repository at this point in the history

  6. apply code suggestion 

    Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
    @castdrian @SpaceEEC
    castdrian and SpaceEEC committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    82abc5b View commit details
    Browse the repository at this point in the history

  7. apply code suggestion 

    Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
    @castdrian @SpaceEEC
    castdrian and SpaceEEC committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    12fec18 View commit details
    Browse the repository at this point in the history

  8. apply code suggestion 

    Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
    @castdrian @SpaceEEC
    castdrian and SpaceEEC committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    abf2672 View commit details
    Browse the repository at this point in the history

  9. fix(Typings): fix syntax & remove unused overload

    @castdrian
    castdrian committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    2c3b536 View commit details
    Browse the repository at this point in the history

  10. fix(Webhook): remove unnecessary call

    @castdrian
    castdrian committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    70f12e9 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2021

  1. Update typings/index.d.ts 

    Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
    @castdrian @SpaceEEC
    castdrian and SpaceEEC committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    a05cd88 View commit details
    Browse the repository at this point in the history

  2. Update typings/index.d.ts 

    Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
    @castdrian @SpaceEEC
    castdrian and SpaceEEC committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    0b472ce View commit details
    Browse the repository at this point in the history