Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Types): include @discordjs/voice typings #5941

Merged
merged 4 commits into from Jun 29, 2021
Merged

chore(Types): include @discordjs/voice typings #5941

merged 4 commits into from Jun 29, 2021

Conversation

amishshah
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

  • Removed @discordjs/voice as a dev dependency
  • Includes the adapter typings from @discordjs/voice
  • Disables skipLibCheck to prevent type errors from going unseen

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
@kyranet
Copy link
Member

kyranet commented Jun 28, 2021 •
edited

I suppose nobody can avoid it, but this PR needs a rebase once #5937 is merged.

kyranet
kyranet approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as this is tested with and without @discordjs/voice, and the types work fine, LGTM.

SpaceEEC
SpaceEEC approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more skipLibCheck 🙏

@iCrawl iCrawl merged commit 63a8df1 into discordjs:master Jun 29, 2021
@beni69 beni69 mentioned this pull request Jul 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@amishshah @kyranet @vladfrangu @iCrawl @SpaceEEC