Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Collections import #6243

Closed
wants to merge 1 commit into from
Closed

Conversation

BannerBomb
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This fixes #6236 which was caused by the @discordjs/collections being deconstructured when importing.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@ckohen
Copy link
Member

ckohen commented Jul 31, 2021

The version of Collection used no longer has an export that can be used as such, destructuring is required. The fix to #6236 is updating dependencies. This would actually break the lib.

@BannerBomb
Copy link
Contributor Author

BannerBomb commented Jul 31, 2021

Oh, yea you're right. I also had an older @discordjs/collections installed when I checked the export. I also looked at the code and saw it had export default Collection and assumed that meant it would be the default import if not deconstructuring but forgot that default was only a typescript thing.

@kyranet
Copy link
Member

kyranet commented Jul 31, 2021

Closing this PR as it's superseded/fixed by #6246

@kyranet kyranet closed this Jul 31, 2021
@BannerBomb BannerBomb deleted the patch-4 branch August 1, 2021 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error from Collection util
3 participants