Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Typings): fix WebhookEditMessageOptions not having attachments #6430

Merged
merged 4 commits into from
Aug 17, 2021
Merged

chore(Typings): fix WebhookEditMessageOptions not having attachments #6430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e177fa
chore(Typings): fix WebhookMessageOptions not having attachments
Milo123459 Aug 14, 2021
cf850a8
feat(Webhook): update jsdoc
Milo123459 Aug 14, 2021
9c21c26
fix(TextBasedChannel): add attachments to MessageOptions
Milo123459 Aug 14, 2021
0b8f9d6
chore(Webhook): fix description
Milo123459 Aug 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/structures/Webhook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ class Webhook {
* @property {string} [content] See {@link BaseMessageOptions#content}
* @property {FileOptions[]|BufferResolvable[]|MessageAttachment[]} [files] See {@link BaseMessageOptions#files}
* @property {MessageMentionOptions} [allowedMentions] See {@link BaseMessageOptions#allowedMentions}
* @property {MessageAttachment[]} [attachments] Attachments to send with the message
* @property {MessageActionRow[]|MessageActionRowOptions[]} [components]
* Action rows containing interactive components for the message (buttons, select menus)
*/
Expand Down
1 change: 1 addition & 0 deletions src/structures/interfaces/TextBasedChannel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ class TextBasedChannel {
* @property {MessageActionRow[]|MessageActionRowOptions[]} [components]
* Action rows containing interactive components for the message (buttons, select menus)
* @property {StickerResolvable[]} [stickers=[]] Stickers to send in the message
* @property {MessageAttachment[]} [attachments] Attachments to send in the message
*/

/**
Expand Down
3 changes: 2 additions & 1 deletion typings/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4181,6 +4181,7 @@ export interface MessageOptions {
files?: (FileOptions | BufferResolvable | Stream | MessageAttachment)[];
reply?: ReplyOptions;
stickers?: StickerResolvable[];
attachments?: MessageAttachment[];
}

export type MessageReactionResolvable =
Expand Down Expand Up @@ -4625,7 +4626,7 @@ export interface WebhookEditData {

export type WebhookEditMessageOptions = Pick<
WebhookMessageOptions,
'content' | 'embeds' | 'files' | 'allowedMentions' | 'components'
'content' | 'embeds' | 'files' | 'allowedMentions' | 'components' | 'attachments'
>;

export interface WebhookMessageOptions extends Omit<MessageOptions, 'reply'> {
Expand Down