Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typings: make channelId non-nullable on MessageComponentInteraction #6600

Merged
merged 6 commits into from Sep 8, 2021
Merged

typings: make channelId non-nullable on MessageComponentInteraction #6600

merged 6 commits into from Sep 8, 2021

Conversation

suneettipirneni
Copy link
Member

@suneettipirneni suneettipirneni commented Sep 7, 2021 •
edited

Please describe the changes this PR makes and why it should be merged:

Closes #6591, references: https://discord.com/developers/docs/interactions/receiving-and-responding#interactions

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@suneettipirneni suneettipirneni changed the title typing: make , , and non-nullable on typings: make channelId, guildId, and member non-nullable on MessageComponentInteraction Sep 7, 2021
@monbrey
Copy link
Member

monbrey commented Sep 7, 2021 •
edited

How is member and guildId non-nullable? Can components not be sent / interacted with in DMs?

@suneettipirneni
Copy link
Member Author

suneettipirneni commented Sep 7, 2021 •
edited

How is member and guildId non-nullable? Can components not be sent / interacted with in DMs?

Yeah I missed this in the docs:

** member is sent when the interaction is invoked in a guild, and user is sent when invoked in a DM

Good catch, this has been reverted.

@suneettipirneni suneettipirneni changed the title typings: make channelId, guildId, and member non-nullable on MessageComponentInteraction typings: make channelId non-nullable on MessageComponentInteraction Sep 7, 2021
@Jiralite
Copy link
Member

Jiralite commented Sep 7, 2021

I believe the documentation should be edited to reflect these changes, no?

@suneettipirneni
Copy link
Member Author

I believe the documentation should be edited to reflect these changes, no?

Updated 😄

@iCrawl iCrawl added this to the Version 13.2 milestone Sep 8, 2021
@iCrawl iCrawl merged commit 8cc3885 into discordjs:main Sep 8, 2021
@suneettipirneni suneettipirneni deleted the typings/messageComponentInteraction-non-nullables branch February 7, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
semver:minor typings
Projects
None yet
Milestone
Version 13.2
Development

Successfully merging this pull request may close these issues.

Feature request: Make MessageComponentInteraction#channelId non-nullable
6 participants
@suneettipirneni @monbrey @Jiralite @iCrawl @kyranet @SpaceEEC