-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ThreadChannel): add ThreadChannel#viewable
#6975
Conversation
ThreadChannel#viewable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whilst this pull request does fix the issue linked, it doesn't fix all instances of it.
Consider the scenario where a thread becomes locked or the client fetches a thread that happens to be locked without the manage threads permission. Then, consider the client fetching a message and running Message#editable
. Through that, the result will be true
but it should be false
because the thread is locked and messages cannot be edited.
Good catch! I'm thinking even if it's locked and you have manage_threads perms |
Right. |
ThreadChannel#viewable
ThreadChannel#viewable
Please describe the changes this PR makes and why it should be merged:
Closes #6969
Status and versioning classification: