refactor(guildbanmanager)!: rename days option to deleteMessageDays #7447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
kyranet
approved these changes
Feb 11, 2022
thebigwolfy
approved these changes
Feb 11, 2022
vladfrangu
approved these changes
Feb 12, 2022
Triple checked it! |
iCrawl
approved these changes
Feb 13, 2022
ImRodry
force-pushed
the
refactor/ban-days
branch
from
b3ac74a
to
2ca4c16
Compare
|
Failing CI because of #7422 |
BREAKING CHANGE: renamed option in BanOptions
ImRodry
force-pushed
the
refactor/ban-days
branch
from
2ca4c16
to
a39528c
Compare
Jiralite
added a commit
to suneettipirneni/guide
that referenced
this pull request
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR renamed the
daysoption in BanOptions todeleteMessageDaysto be inline with the API name and to avoid confusion with users thinking it's a way to tempban people, which it's not. It also removes the default of 0 since that's handled by the API (not documented, but it is 0)Status and versioning classification: