refactor(RichPresenceAssets): Remove undocumented checks #7637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
kyranet
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
I don't know why the thumbs down, but if it's undocumented, we shouldn't support it, since it can change anytime without previous notice.
And obviously, if you somehow rely on this to work fine, you're in big trouble once the format changes (if it does) and you get invalid images as a result.
If any you really need it, you can always make your own function supporting those platforms.
So yeah, LGTM.
vladfrangu
approved these changes
Mar 14, 2022
iCrawl
approved these changes
Mar 15, 2022
"Hypothetically" is not a good reason lol |
SpaceEEC
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
As per discord/discord-api-docs#4617, the following parsing should be removed:
It seems the media proxy is fine to stay.
This resolves #7635.
Status and versioning classification: