Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow emoji strings to be passed through constructors #7718

Merged
merged 2 commits into from
Apr 12, 2022
Merged

feat: allow emoji strings to be passed through constructors #7718

merged 2 commits into from
Apr 12, 2022

Conversation

ImRodry
Copy link
Contributor

@ImRodry ImRodry commented Mar 27, 2022

Please describe the changes this PR makes and why it should be merged:
This PR adds the feature from #7616 to builder constructors

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@ImRodry ImRodry changed the title feat: allow strings to be passed through constructors feat: allow emoji strings to be passed through constructors Mar 27, 2022
@ImRodry ImRodry requested a review from vladfrangu April 3, 2022 14:27
kyranet
kyranet reviewed Apr 10, 2022
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question:

packages/discord.js/src/structures/ButtonBuilder.js Show resolved Hide resolved
@iCrawl iCrawl modified the milestones: builders v1, discord.js v14 Apr 12, 2022
@iCrawl iCrawl merged commit 0faac04 into discordjs:main Apr 12, 2022
@ImRodry ImRodry deleted the feat/emoji-strings-constructors branch April 12, 2022 21:57
@muchnameless muchnameless mentioned this pull request Apr 13, 2022
Merged
@ImRodry ImRodry mentioned this pull request Apr 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranet kyranet kyranet left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js v14
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ImRodry @vladfrangu @iCrawl @kyranet @SpaceEEC