fix(InteractionCreateAction): Ensure text-based channel for caching messages #7755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
Jiralite
changed the title
The event will emit for these types of bots. However, as the channel is not from a cached guild, they are safe from this crash.
xMooddyy
suggested changes
Apr 6, 2022
kyranet
approved these changes
Apr 6, 2022
This was referenced Apr 6, 2022
iCrawl
approved these changes
Apr 9, 2022
SpaceEEC
approved these changes
Apr 9, 2022
vladfrangu
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Text-in-Voice channels are gradually rolling out. When an interaction from a component is received in such a channel, discord.js will crash as it attempts to cache the respective message as we do not provide a message cache for voice channels.
This has been resolved by verifying that the channel an interaction came from is text-based (if it is going to cache the respective message). This logic has been applied to message context menu command interactions too despite being currently unusable in text-in-voice channels, but it is better to be safe than sorry.
This pull request resolves #7749.
Status and versioning classification: