Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WebhookClient): Updated webhook url to include old url #7767

Closed
wants to merge 1 commit into from
Closed

fix(WebhookClient): Updated webhook url to include old url #7767

wants to merge 1 commit into from

Conversation

bleuthoot-sven
Copy link

Please describe the changes this PR makes and why it should be merged:

Fixed the webhook url to include the old discordapp.com url. When copying a webhook URL directly from Discord, it still uses the old URL. This causes the URL check to fail, even though it is a valid URL.

Quite some time ago, this check was not added or removed because discord was switching to the discord.com URL. However, as of writing this Merge Request, discord still uses the old discordapp.com URL when copying a webhook URL using the client. Someone else tried to fix this, but it was mentioned it was an intentional change.

I would like for this to be added (back), because discord still uses discordapp.com when copying the url.

https://i.imgur.com/6WENtTf.mp4

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Fixed the webhook url to include the old discordapp.com url. When copying a webhook URL directly from Discord, it still uses the old url. This causes the url check to fail, even though it is a valid URL.
@almeidx
Copy link
Member

almeidx commented Apr 10, 2022

The up-to-date clients use the discord.com domain

@imranbarbhuiya
Copy link
Contributor

#6192 (comment)

@bleuthoot-sven
Copy link
Author

The up-to-date clients use the discord.com domain

I am pretty sure my discord client is up-to-date, since I just installed this client today.

@xHyroM
Copy link
Contributor

xHyroM commented Apr 10, 2022

The up-to-date clients use the discord.com domain

I am pretty sure my discord client is up-to-date, since I just installed this client today.

Are you sure? I tested it now on Stable 123305 (2d81cde3774b39f14994d35176c48e61fd1bf371) and Canary 12387 (14782d332eb3ca362a797e79fcf9f3eab3a2d2b2) and discord returns me the url (canary).discord.com when I copy the links.

@bleuthoot-sven
Copy link
Author

The up-to-date clients use the discord.com domain

I am pretty sure my discord client is up-to-date, since I just installed this client today.

Are you sure? I tested it now on Stable 123305 (2d81cde3774b39f14994d35176c48e61fd1bf371) and Canary 12387 (14782d332eb3ca362a797e79fcf9f3eab3a2d2b2) and discord returns me the url (canary).discord.com when I copy the links.

Ok, this is weird. I just booted up my PC again without changing anything and it seems to be updated and use the correct url now. Weird because I would assume a newly installed discord installation would have the most recent version installed.

I apologize for wasting your time. I will try to check better next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants