Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ApplicationCommandManager): allow passing 0n to defaultMemberPermissions #8311

Merged
merged 2 commits into from Jul 20, 2022
Merged

fix(ApplicationCommandManager): allow passing 0n to defaultMemberPermissions #8311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d57b72c
fix(ApplicationCommandManager): allow passing 0n to defaultMemberPerm…
almeidx Jul 18, 2022
541c59f
fix(ApplicationCommand): equals()
almeidx Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/discord.js/src/managers/ApplicationCommandManager.js
View file
Open in desktop
Expand Up @@ -242,9 +242,10 @@ class ApplicationCommandManager extends CachedManager {
}

if ('defaultMemberPermissions' in command) {
default_member_permissions = command.defaultMemberPermissions
? new PermissionsBitField(command.defaultMemberPermissions).bitfield.toString()
: command.defaultMemberPermissions;
default_member_permissions =
command.defaultMemberPermissions !== null
? new PermissionsBitField(command.defaultMemberPermissions).bitfield.toString()
: command.defaultMemberPermissions;
}

return {
Expand Down
7 changes: 4 additions & 3 deletions packages/discord.js/src/structures/ApplicationCommand.js
View file
Open in desktop
Expand Up @@ -365,9 +365,10 @@ class ApplicationCommand extends Base {
}

if ('defaultMemberPermissions' in command) {
defaultMemberPermissions = command.defaultMemberPermissions
? new PermissionsBitField(command.defaultMemberPermissions).bitfield
: null;
defaultMemberPermissions =
command.defaultMemberPermissions !== null
? new PermissionsBitField(command.defaultMemberPermissions).bitfield
: null;
}

// Check top level parameters
Expand Down