Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove ActionRow.from() #8502

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Syjalo
Copy link
Contributor

@Syjalo Syjalo commented Aug 16, 2022

Please describe the changes this PR makes and why it should be merged:
This PR removes ActionRow.from() since it contains incorrect docs, has no types and shouldn't be in a component.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@vercel
Copy link

vercel bot commented Aug 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Aug 16, 2022 at 3:43PM (UTC)

@vladfrangu
Copy link
Member

vladfrangu commented Aug 16, 2022

Doesn't this go against the RFC?

EDIT: Misread, thought this was about builders

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #8502 (29d0616) into main (acdafe6) will increase coverage by 26.74%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #8502       +/-   ##
===========================================
+ Coverage   59.54%   86.29%   +26.74%     
===========================================
  Files          12       87       +75     
  Lines        1466     8362     +6896     
  Branches       87     1105     +1018     
===========================================
+ Hits          873     7216     +6343     
- Misses        592     1103      +511     
- Partials        1       43       +42     
Flag Coverage Δ
builders 100.00% <ø> (?)
collection 100.00% <ø> (?)
proxy 73.28% <ø> (?)
rest 92.53% <ø> (?)
utilities 100.00% <ø> (?)
voice 64.08% <ø> (?)
ws 59.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/voice/src/joinVoiceChannel.ts 100.00% <0.00%> (ø)
packages/voice/src/audio/TransformerGraph.ts 74.60% <0.00%> (ø)
packages/builders/src/components/Component.ts 100.00% <0.00%> (ø)
packages/actions/src/formatTag/formatTag.ts 100.00% <0.00%> (ø)
...ashCommands/mixins/ApplicationCommandOptionBase.ts 100.00% <0.00%> (ø)
packages/voice/src/receive/SSRCMap.ts 86.20% <0.00%> (ø)
.../src/interactions/slashCommands/options/boolean.ts 100.00% <0.00%> (ø)
packages/rest/src/lib/REST.ts 98.86% <0.00%> (ø)
...ixins/ApplicationCommandOptionChannelTypesMixin.ts 100.00% <0.00%> (ø)
packages/builders/src/interactions/modals/Modal.ts 100.00% <0.00%> (ø)
... and 65 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jiralite
Copy link
Member

Jiralite commented Aug 16, 2022

Can you make a pull request to emit a deprecation warning to use the ActionRowBuilder's static method?

@Jiralite Jiralite removed this from the discord.js v14.3 milestone Aug 17, 2022
@CitTheDev
Copy link
Contributor

I just checked the src/structures/ActionRow.js and it does emit a deprecation warning.

@Jiralite
Copy link
Member

Jiralite commented Oct 10, 2022

That would be because of #8504. The communication wasn't good here, but thank you for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

None yet

4 participants