Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GuildMemberManager): add() method throws an error #8539

Merged
merged 2 commits into from Aug 21, 2022
Merged

fix(GuildMemberManager): add() method throws an error #8539

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76af4e5
fix(GuildMemberManager): `add()` method throws an error
Syjalo Aug 21, 2022
a0cfd2f
chore: update comment
Syjalo Aug 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/discord.js/src/managers/GuildMemberManager.js
View file
Open in desktop
@@ -1,6 +1,5 @@
'use strict';

const { Buffer } = require('node:buffer');
const { setTimeout, clearTimeout } = require('node:timers');
const { Collection } = require('@discordjs/collection');
const { makeURLSearchParams } = require('@discordjs/rest');
Expand Down Expand Up @@ -128,8 +127,12 @@ class GuildMemberManager extends CachedManager {
resolvedOptions.roles = resolvedRoles;
}
const data = await this.client.rest.put(Routes.guildMember(this.guild.id, userId), { body: resolvedOptions });
// Data is an empty buffer if the member is already part of the guild.
return data instanceof Buffer ? (options.fetchWhenExisting === false ? null : this.fetch(userId)) : this._add(data);
// Data is an empty Uint8Array if the member is already part of the guild.
return data instanceof Uint8Array
? options.fetchWhenExisting === false
? null
: this.fetch(userId)
: this._add(data);
}

/**
Expand Down