Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New select menus #8775

Closed
wants to merge 38 commits into from
Closed

New select menus #8775

wants to merge 38 commits into from

Conversation

jaw0r3k
Copy link
Contributor

@jaw0r3k jaw0r3k commented Oct 21, 2022

Please describe the changes this PR makes and why it should be merged:
New Selects
Collaborating with @RedGuy12

Status and versioning classification:

jaw0r3k and others added 16 commits October 14, 2022 11:14
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Oct 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Oct 31, 2022 at 10:18AM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Oct 31, 2022 at 10:18AM (UTC)

jaw0r3k and others added 3 commits October 21, 2022 17:18
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
 into new-select-menus

Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
@jaw0r3k jaw0r3k marked this pull request as ready for review October 22, 2022 22:48
@TrevorSayre
Copy link

TrevorSayre commented Oct 23, 2022

Addresses #8753

Copy link
Contributor

@Syjalo Syjalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run yarn format

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
* Collection of the selected users
* @type {Collection<Snowflake, GuildMember|APIGuildMember>?}
*/
this.members = new Collection();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

packages/discord.js/src/util/Constants.js Outdated Show resolved Hide resolved
@didinele didinele mentioned this pull request Oct 28, 2022
Co-authored-by: Julian Vennen <julian@aternos.org>
@kyranet
Copy link
Member

kyranet commented Nov 1, 2022

Closing since we'll go for #8793 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet