Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Webhook): add channel property #8812

Merged
merged 5 commits into from
Nov 26, 2022
Merged

feat(Webhook): add channel property #8812

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c05faae
feat(Webhook): add `channel` property
MrMythicalYT Nov 4, 2022
5c018cd
fix: allow ForumChannel type
MrMythicalYT Nov 5, 2022
acaedb8
fix: disallow thread channel type
MrMythicalYT Nov 5, 2022
97be09d
fix: formatting
MrMythicalYT Nov 6, 2022
ccb21bb
Apply suggestions from code review
MrMythicalYT Nov 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/discord.js/src/structures/Webhook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class Webhook {

if ('channel_id' in data) {
/**
* The channel the webhook belongs to
* The id of the channel the webhook belongs to
* @type {Snowflake}
*/
this.channelId = data.channel_id;
Expand Down Expand Up @@ -140,7 +140,14 @@ class Webhook {
* @property {Snowflake} [threadId] The id of the thread this message belongs to
* <info>For interaction webhooks, this property is ignored</info>
*/

/**
MrMythicalYT marked this conversation as resolved.
Show resolved Hide resolved
* The channel that this webhook belongs to
MrMythicalYT marked this conversation as resolved.
Show resolved Hide resolved
* @type {?(GuildTextBasedChannel|ForumChannel)}
MrMythicalYT marked this conversation as resolved.
Show resolved Hide resolved
* @readonly
*/
get channel() {
return this.client.channels.resolve(this.channelId);
}
MrMythicalYT marked this conversation as resolved.
Show resolved Hide resolved
/**
* Sends a message with this webhook.
* @param {string|MessagePayload|WebhookCreateMessageOptions} options The options to provide
Expand Down
1 change: 1 addition & 0 deletions packages/discord.js/typings/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2908,6 +2908,7 @@ export class Webhook extends WebhookMixin() {
public token: string | null;
public type: WebhookType;
public applicationId: Snowflake | null;
public get channel(): GuildTextBasedChannel | ForumChannel | null;
public isUserCreated(): this is this & {
type: WebhookType.Incoming;
applicationId: null;
Expand Down