Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-export formatters #8909

Merged
merged 4 commits into from Dec 12, 2022
Merged

Conversation

muchnameless
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
#8699 for @discordjs/formatters

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Dec 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Dec 12, 2022 at 8:46AM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Dec 12, 2022 at 8:46AM (UTC)

@almeidx
Copy link
Member

almeidx commented Dec 5, 2022

Shouldn't it be re-exported in the typings as well?

@Syjalo
Copy link
Contributor

Syjalo commented Dec 6, 2022

Should this be even re-exported for v14? Formatters are still in builders.

@almeidx
Copy link
Member

almeidx commented Dec 6, 2022

Given that builders just re-exports @discordjs/formatters, you cannot use the named exports from /formatters in djs with ESM, as described in the mentioned pr

@Jiralite Jiralite added this to the discord.js v14.8 milestone Dec 6, 2022
@kodiakhq kodiakhq bot merged commit b14604a into discordjs:main Dec 12, 2022
@muchnameless muchnameless deleted the fix-formatters branch December 12, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants