Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Message): bulkDeletable permissions should be retrieved later for DMs #9146

Merged
merged 3 commits into from
Feb 25, 2023
Merged

fix(Message): bulkDeletable permissions should be retrieved later for DMs #9146

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ac0ed4
fix(Message): permissions check should be done later
NotSugden Feb 18, 2023
15a5c3c
refactor: remove unessercary chaining
NotSugden Feb 18, 2023
e9a0fcd
Merge branch 'main' into patch-1
NotSugden Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/discord.js/src/structures/Message.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,12 +645,11 @@ class Message extends Base {
* channel.bulkDelete(messages.filter(message => message.bulkDeletable));
*/
get bulkDeletable() {
const permissions = this.channel?.permissionsFor(this.client.user);
return (
(this.inGuild() &&
Date.now() - this.createdTimestamp < MaxBulkDeletableMessageAge &&
this.deletable &&
permissions?.has(PermissionFlagsBits.ManageMessages, false)) ??
this.channel?.permissionsFor(this.client.user).has(PermissionFlagsBits.ManageMessages, false)) ??
NotSugden marked this conversation as resolved.
Show resolved Hide resolved
false
);
}
Expand Down