refactor: remove zlib-sync #9279
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@didinele is attempting to deploy a commit to the discordjs Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-guide-git-fork-didinele-refactor-na-c3e2f9-discordjs.vercel.app/ |
Codecov Report
@@ Coverage Diff @@
## main #9279 +/- ##
==========================================
- Coverage 83.54% 83.53% -0.02%
==========================================
Files 100 100
Lines 9574 9578 +4
Branches 1103 1103
==========================================
+ Hits 7999 8001 +2
- Misses 1535 1537 +2
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -482,7 +479,7 @@ export class WebSocketShard extends AsyncEventEmitter<WebSocketShardEventsMap> { | |||
| this.debug([ | |||
| 'Received a message we were unable to decompress', | |||
| `isBinary: ${isBinary.toString()}`, | |||
| `useIdentifyCompress: ${this.useIdentifyCompress.toString()}`, | |||
| `useIdentifyCompress: ${this.useIdentifyCompression.toString()}`, | |||
There was a problem hiding this comment.
| `useIdentifyCompress: ${this.useIdentifyCompression.toString()}`, | |
| `useIdentifyCompression: ${this.useIdentifyCompression.toString()}`, |
|
Just a small followup to this issue: |
|
closing in favor of a new PR since this has the branch on my fork and it's just a whole mess to work with. |
Please describe the changes this PR makes and why it should be merged:
draft because vlad wants us to keep zlib-sync & the new pure-native node:zlib impl together for a few dev releases
Status and versioning classification: