Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Voice Channel Send Effects #9288
base: main
Are you sure you want to change the base?
feat: Voice Channel Send Effects #9288
Changes from all commits
93968d2
f8d473d
57f960d
79617a5
7dda110
7e6b004
4a1e935
457e971
1d01821
506adb0
b27c1d0
f932634
f19b0df
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not. Extending
Base
would mean this would (not publically) add_clone()
,_patch()
, and_update()
to the class which are all irrelevant methods. In addition,valueOf()
for this structure would returnundefined
as there is noid
sent in voice channel effects.