Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BitField): use only enum names in iterating #9377

Closed
wants to merge 2 commits into from

Conversation

jaw0r3k
Copy link
Contributor

@jaw0r3k jaw0r3k commented Apr 13, 2023

Please describe the changes this PR makes and why it should be merged:
Backports to v13:

Status and versioning classification:

  • Typings don't need updating
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Apr 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Apr 13, 2023 5:09pm

@vercel
Copy link

vercel bot commented Apr 13, 2023

@jaw0r3k is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
@vladfrangu
Copy link
Member

Just curious, does this version even have the same bug? 👁️

@Jiralite
Copy link
Member

Probably? 630d4f3

Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to see anything to fix here, we don't seem to use any TS-enums in v13. 😅
(Otherwise this would probably need to be applied to serialize too.)

@jaw0r3k
Copy link
Contributor Author

jaw0r3k commented Apr 15, 2023

Well you are right, v13 uses only pure objects

@jaw0r3k jaw0r3k closed this Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants