-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: "hide" ./defaultWorker
entrypoint with types: null
#9485
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
types
condition to the front./defaultWorker
entrypoint with types: null
@didinele adjusted the content and the PR's title, would you mind taking another look? |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-git-fork-andarist-fix-types-condition-discordjs.vercel.app/ |
Codecov Report
@@ Coverage Diff @@
## main #9485 +/- ##
==========================================
- Coverage 58.56% 58.53% -0.03%
==========================================
Files 226 227 +1
Lines 14762 14769 +7
Branches 1266 1267 +1
==========================================
Hits 8645 8645
- Misses 6077 6084 +7
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I moved
types
condition to the front.package.json#exports
are order-sensitive - they are always matched from the top to the bottom. When a match is found then it should be used and no further matching should occur.Right now, the current setup works in TypeScript but it's considered a bug and it should not be relied upon, see the thread and the comment here. For that reason, I would like to fix all popular packages that misconfigured their
exports
this way so the bug can be fixed in TypeScript.This is basically the same kind of a PR that was already merged in here: discordjs/discord-api-types#763