-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: v13 Code Samples
.
#721
Merged
Danktuary
merged 30 commits into
discordjs:v13-prep
from
WiseDevHelper:v13-code-samples
Jul 29, 2021
Merged
feat: v13 Code Samples
.
#721
Danktuary
merged 30 commits into
discordjs:v13-prep
from
WiseDevHelper:v13-code-samples
Jul 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
up and running.
Danktuary
reviewed
Jul 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🎉
The sharding code samples were updated in #695, and voice doesn't have any code samples files, so only the reactions file is left on your task list
…3-code-samples
Co-authored-by: Danktuary <sanc.pw@gmail.com>
Moved Reactions to #729 since it should have a PR of it's own. |
Danktuary
approved these changes
Jul 25, 2021
Danktuary
reviewed
Jul 25, 2021
Danktuary
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
(Split from #708)
Demo
This PR updates the
Code Samples
of the guide for thev13
release. It also updates other files to maintain consistency.Status
Code Samples
.Adding features.(Removed. Refer refactor(Commandhandling): rewrite command handling pages to be based upon interactions #683 (comment))Commando(To be removed in feat: Sapphire guide #711)Commands with user input.(Removed. Refer refactor(Commandhandling): rewrite command handling pages to be based upon interactions #683 (comment))Permissions
. #705)Reactions
. #729)Webhooks
. #700)Shard#broadcastEval
to v13 syntax. #695)Please let me know if there is more to change. I'll be happy to work on them.