Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v13 Code Samples. #721

Merged
merged 30 commits into from
Jul 29, 2021
Merged

Conversation

WiseDevHelper
Copy link
Contributor

@WiseDevHelper WiseDevHelper commented Jul 19, 2021

Please describe the changes this PR makes and why it should be merged:

(Split from #708)

Demo

This PR updates the Code Samples of the guide for the v13 release. It also updates other files to maintain consistency.

Status

Please let me know if there is more to change. I'll be happy to work on them.

@WiseDevHelper WiseDevHelper marked this pull request as draft July 24, 2021 11:28
Copy link
Member

@Danktuary Danktuary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

The sharding code samples were updated in #695, and voice doesn't have any code samples files, so only the reactions file is left on your task list

code-samples/sequelize/currency/13/app.js Outdated Show resolved Hide resolved
guide/sequelize/currency.md Outdated Show resolved Hide resolved
@WiseDevHelper WiseDevHelper mentioned this pull request Jul 25, 2021
2 tasks
@WiseDevHelper
Copy link
Contributor Author

Moved Reactions to #729 since it should have a PR of it's own.

@WiseDevHelper WiseDevHelper marked this pull request as ready for review July 25, 2021 17:02
@Danktuary Danktuary merged commit ba92fab into discordjs:v13-prep Jul 29, 2021
@WiseDevHelper WiseDevHelper deleted the v13-code-samples branch July 30, 2021 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants