Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates warning about ephemeral fetching. #908

Merged
merged 1 commit into from Oct 11, 2021
Merged

Updates warning about ephemeral fetching. #908

merged 1 commit into from Oct 11, 2021

Conversation

SethCohen
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Ephemeral fetching was added in v13.2.0 (#6426) (d289d5c)

Ephemeral fetching was added in 13.2.0. #6426
Copy link
Member

@almostSouji almostSouji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is possible now, this might as well mention how to do it.

@SethCohen
Copy link
Contributor Author

Since it is possible now, this might as well mention how to do it.

It already mentions how to fetch the reply right below.

@almostSouji
Copy link
Member

Oh right, forgot to fold out and assert position, so this just updates the block to no longer mention that the deleting on ephems is impossible

@almostSouji almostSouji dismissed their stale review October 11, 2021 18:13

not applicable

@almostSouji almostSouji merged commit ef008f1 into discordjs:main Oct 11, 2021
@SethCohen SethCohen deleted the patch-1 branch October 11, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants