UX: add illustrations for empty chat list + split into tabs on drawer #26910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chat
jjaffeux
force-pushed
the
chat-illustrations-empty-list
branch
from
a140fb4
to
51dd237
Compare
…scourse/discourse into chat-illustrations-empty-list
|
I like the splash image for empty channel lists, very nice.. I wonder if we need the "0" though? Not sure if it's just me but feels a little strange having it there on top of the graphic. |
dbattersby
reviewed
May 13, 2024
plugins/chat/assets/javascripts/discourse/components/channels-list-public.gjs
Outdated
Show resolved
Hide resolved
|
Just a reminder in case I forget later, I think we need to fix this UX issue first where channels and DMs are split |
chapoi
changed the title
ZogStriP
reviewed
May 27, 2024
ZogStriP
reviewed
May 27, 2024
Co-authored-by: Régis Hanol <regis@hanol.fr>
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/new-strings-from-discourse-discourse-arent-added-to-crowdin/309802/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Juicing Discourse by adding a placeholder image + CTA in chat, for empty channel and DM lists.
Drawer
Mobile
Desktop (header dropdown navigation)