FIX: Update do-not-disturb icon in real-time on glimmer header #27021
Conversation
davidtaylorhq
force-pushed
the
glimmer-header-dnd-live
branch
from
0ecb8fb
to
4604fbe
Compare
|
@davidtaylorhq how do you feel about |
|
Yeah for sure - I hope it will be useful elsewhere! |
To achieve this, a new ReactiveTargetDate 'resource' is introduced. This is constructed using a callback, which should return the target date (in this case, when do-not-disturb will end). The utility then provides an autotrackable `.hasPassed` getter which returns a boolean. This resource needs to be properly torn down at the end of the application lifecycle in tests, so the logic is moved out of the user model and into a new Notifications service.
davidtaylorhq
force-pushed
the
glimmer-header-dnd-live
branch
from
4604fbe
to
79752b1
Compare
| } | ||
|
|
||
| willDestroy() { | ||
| this.#dndReactiveTargetDate?.destroy(); |
There was a problem hiding this comment.
wouldn't it be better to use the getOwner/setOwner pattern so that it gets destroyed automatically?
you can forget calling the destructor but you can't forget passing in a "required"/first argument 😛
There was a problem hiding this comment.
That was my first try. But unfortunately getOwner/setOwner is separate from Ember's "destroyable" system. Destroying the application does not automatically destroy things which are owned by it. 😬
But yeah, I do agree this manual stuff is not ideal. Will see if I can figure something out 🤔
To achieve this, a new ReactiveTargetDate 'resource' is introduced. This is constructed using a callback, which should return the target date (in this case, when do-not-disturb will end). The utility then provides an autotrackable
.hasPassedgetter which returns a boolean.This resource needs to be properly torn down at the end of the application lifecycle in tests, so the logic is moved out of the user model and into a new Notifications service.