DEV: Update LinkedIn OIDC client secret validation format #27028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/configure-linkedin-openid-connect-login-for-discourse/305366/5 |
nattsw
approved these changes
May 15, 2024
|
We can't get a regex properly right? I mean by looking at LinkedIn's docs or something to ensure there are no additional special characters Right - https://learn.microsoft.com/en-us/linkedin/shared/authentication/client-credentials-flow - they don't share what it can "look" like 😮💨 |
nattsw
reviewed
May 15, 2024
| @@ -512,7 +512,7 @@ login: | |||
| regex: "^[a-z0-9]+$" | |||
| linkedin_oidc_client_secret: | |||
| default: "" | |||
| regex: "^[a-zA-Z0-9]+$" | |||
| regex: "^[a-zA-Z0-9_=\\.]+$" | |||
There was a problem hiding this comment.
You need to use double escape because it's in a YAML file. The first one escapes the second in YAML, the second one escapes the dot in the regular expression. (You can search \\. in site_settings.yml for other examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meta
What is this change?
The LinkedIn OIDC client secret used to look something like:
but now they are generating secrets that look like:
This updates the regular expression used for validation to reflect this.