Change GuildPrivateThreadCreate to have NonInvitable field instead of Invitable #379
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd rather have this be a pointer instead to be consistent with other fields & the discord docs |
Definitely a saner way to do it 😅 |
|
sane is arguable in this case, getting pointers from primitives is annoying after all lol |
|
thanks |
adalinesimonian
referenced
this pull request
in NLLCommunity/heimdallr
Aug 31, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/disgoorg/disgo](https://togithub.com/disgoorg/disgo) | `v0.18.10` -> `v0.18.11` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>disgoorg/disgo (github.com/disgoorg/disgo)</summary> ### [`v0.18.11`](https://togithub.com/disgoorg/disgo/releases/tag/v0.18.11): - Entry point commands, subscriptions and more [Compare Source](https://togithub.com/disgoorg/disgo/compare/v0.18.10...v0.18.11) #### What's Changed - Add entry point commands + callback updates by [@​sebm253](https://togithub.com/sebm253) in [https://github.com/disgoorg/disgo/pull/390](https://togithub.com/disgoorg/disgo/pull/390) - Add subscriptions by [@​sebm253](https://togithub.com/sebm253) in disgoorg/disgo@fcbf484 - Add `GuildVoiceChannelEffectSend` by [@​sebm253](https://togithub.com/sebm253) in [https://github.com/disgoorg/disgo/pull/282](https://togithub.com/disgoorg/disgo/pull/282) - Add `rest.GetActivityInstance` by [@​sebm253](https://togithub.com/sebm253) in disgoorg/disgo@a979bbb - Add poll result messages by [@​sebm253](https://togithub.com/sebm253) in [https://github.com/disgoorg/disgo/pull/374](https://togithub.com/disgoorg/disgo/pull/374) - Add newly documented member flags by [@​sebm253](https://togithub.com/sebm253) in disgoorg/disgo@3c62607 - Add `rest.GetActiveGuildThreads` by [@​myrkvi](https://togithub.com/myrkvi) in [https://github.com/disgoorg/disgo/pull/381](https://togithub.com/disgoorg/disgo/pull/381) - Change `GuildPrivateThreadCreate.Invitable` to a pointer by [@​myrkvi](https://togithub.com/myrkvi) in [https://github.com/disgoorg/disgo/pull/379](https://togithub.com/disgoorg/disgo/pull/379) - Expose cache interfaces by [@​topi314](https://togithub.com/topi314) in [https://github.com/disgoorg/disgo/pull/382](https://togithub.com/disgoorg/disgo/pull/382) - Remove `Summary` from `Application` by [@​sebm253](https://togithub.com/sebm253) in disgoorg/disgo@ba3906d #### Breaking Changes - `GuildPrivateThreadCreate.Invitable` has been changed from `bool` to `*bool` - `Summary` has been removed from `Application`. this field was an empty string for a long time **Full Changelog**: disgoorg/disgo@v0.18.10...v0.18.11 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/NLLCommunity/heimdallr). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
apricotbucket28
pushed a commit
to apricotbucket28/disgo
that referenced
this pull request
Feb 16, 2025
… Invitable (disgoorg#379) * fix: Invitable=false does nothing since it is annotated as omitempty. * fix: Use pointer to bool for Invitable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation has the field
Invitableand the JSON annotationomitempty, which results in the field being omitted when it is false. Not explicitly setting an invitable state should result in it being invitable, and as such, havingNonInvitableachieves this.