Update to go 1.16, and run CI on 1.15.x and 1.16.x

[thaJeztah]

corresponding PR for the 2.7 branch is #3472

fixes #3484

[wy65701436]

for the main, we can update the go.mod as well?

[thaJeztah]

for the main, we can update the go.mod as well?

It's already on go1.15, is there a reason for marking 1.15 as "not supported"?

[thaJeztah]

I suspect the repository configuration needs to be updated because the build is now multiple options (go1.15, go1.16);

[wy65701436]

lgtm

[codecov-commenter]

Codecov Report

Merging #3474 (a07b54e) into main (38ab4c6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3474   +/-   ##
=======================================
  Coverage   56.38%   56.38%           
=======================================
  Files         102      102           
  Lines        7324     7324           
=======================================
  Hits         4130     4130           
  Misses       2541     2541           
  Partials      653      653           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38ab4c6...a07b54e. Read the comment docs.

[milosgajdos]

I think adding a build matrix may have broken mandatory status check requirements settings on this repo 🤔
It's stuck in the yellow-ish state

[thaJeztah]

@milosgajdos yup; #3474 (comment). I guess someone with admin privileges needs to modify the configuration

[milosgajdos]

Oh, gotcha, @thaJeztah . I somehow missed that 🤦‍♂️ Ok, I think we need an extra job that checks that all matrix sub-jobs succeed https://github.community/t/status-check-for-a-matrix-jobs/127354

[thaJeztah]

Looks like the proposed solution there may not work 🤔 https://github.community/t/status-check-for-a-matrix-jobs/127354/9

[milosgajdos]

Sadness.

@chrispat can you suggest what we can do here?

[chrispat]

The only option right now would be to update the required checks to include the new checks that are created with the matrix and remove the build check. Having the ability to require a whole matrix is on our backlog.

[thaJeztah]

Thanks @chrispat - I was looking at the page that @milosgajdos linked to, and (and reading the reference), and wondering if using success() instead of always(), combined with needs: <something> would work, but didn't try yet.

I guess changing the config should do the trick for now (I don't think I have the permissions to change it though); would that invalidate all existing PRs though?

[milosgajdos]

would that invalidate all existing PRs though?

yeah, I think we'd have to re-trigger them -- but first theyd also have to be rebased 🤔

[thaJeztah]

We could temporarily remove them as "required" (assuming we don't merge on "red" anyway, and we already have other tests that are required)

[milosgajdos]

We could temporarily remove them as "required" (assuming we don't merge on "red" anyway

Hm, we could, but I'm a bit cautious because if a build fails and someone accidentally merges, all pandas become sad somewhere. We do have e2e and conformance required checks, though so those might just be find for the time being

[thaJeztah]

You don't trust people to only merge when it's green?

[milosgajdos]

I've disabled the requirement on build for the time being until GH add the option to require a whole matrix ✅

[thaJeztah]

Thanks! Looks like that worked; all ✅ now