[release/2.8] Update AWS SDK Go #3894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
|
I'm not sure if we want to do this in a patch release for 2.x, and might be better to leave this for v3
|
|
This has been discussed on multiple occasions: |
|
Fair enough. Then I will close this PR but getting at least an alpha release of v3 out would be good I think. Hopefully that would also get some more activity going and have people contribute to the milestones left for the stable v3 release. |
|
For future reference, #3599 actually makes the change I attempted to do here but likely much better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3275
This PR attempts to update the AWS SDK on the 2.8 release branch, since it doesn't seem like a new release will happen soon. Updating the AWS SDK would solve issues with using IRSA, which has caused issues for a number of users as well as downstream projects such as goharbor/harbor#12888.