New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otel-tracing] Initial opentelemetry support. Rebase of 3701 #3996
Conversation
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
624b9b5
to
c794b99
Compare
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #3996 +/- ##
==========================================
- Coverage 55.85% 55.46% -0.40%
==========================================
Files 110 110
Lines 11069 11183 +114
==========================================
+ Hits 6183 6203 +20
- Misses 4193 4283 +90
- Partials 693 697 +4
☔ View full report in Codecov by Sentry. |
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Good news: experimental OpenTelemetry tracing support has been added to the latest Google Cloud SDK! With a dependency bump and an environment variable set, tracing through the gcs driver would Just Work! Tracing through the azure driver will be almost as easy to enable with the support built into the Azure SDK. As for S3, otel tracing support exists... for AWS SDK v2. At least the work already put into this PR won't go to waste. Note for anyone willing to continue this work: see #3701 (review) which is all still relevant. |
I had a look into this. And it'd appear Correct me if I'm wrong though, please. |
@milosgajdos you are wrong. We can raise the version floor of a transitive dependency in our own go.mod if we want, because all Go modules are semver by decree. |
Ah, right. Ooof I completely missed Line 38 in 60e7e87
|
Closing as outdated but more importantly the basics have been put in place in #4188 |
#3701 was closed due to an issue with rebasing and losing all the changes. This PR is an attempt to revive the changes from the original PR from @lengrongfu.
Original PR comment: