Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace ListObjectsV2 with HeadObject to speed up Stat #4326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DHmc133
Copy link

@DHmc133 DHmc133 commented Apr 16, 2024

replace listObject usr HeadObject can accelerate image push

@milosgajdos
Copy link
Member

@DHmc133 can you please

  1. Describe what you are trying to achieve and the motivations behind the PR
  2. Always sign your commit

Looks like there is a conflict that needs resolving

@DHmc133
Copy link
Author

DHmc133 commented Apr 17, 2024

@DHmc133 can you please

  1. Describe what you are trying to achieve and the motivations behind the PR
  2. Always sign your commit

Looks like there is a conflict that needs resolving

We found that the listObject request will list the full amount of data to find the corresponding key, and the HeadObject can directly get the key's attributes;
Generally speaking, in large image scenarios, it can effectively improve the speed of image push.

@milosgajdos
Copy link
Member

@DHmc133 your PR is broken and fails to build. As I said, you also need to sign your commit.

Copy link

@OKEAMAH OKEAMAH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uj

@squizzi
Copy link
Collaborator

squizzi commented Apr 22, 2024

@DHmc133 please update your commit as well... Update s3.go isn't a good commit message, please follow the conventional commits spec as well when writing your commit. Perhaps something like:

perf: replace ListObjectsV2 with HeadObject to speed up Stat

OKEAMAH

This comment was marked as spam.

@DHmc133 DHmc133 changed the title Update s3.go replace ListObjectsV2 with HeadObject to speed up Stat Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants