Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle wrapper to 8.7 #556

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

infotexture
Copy link
Member

Description

Update Gradle distribution version & regenerate wrapper to pick up recent changes per https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:upgrading_wrapper

./gradlew wrapper --gradle-version 8.7
./gradlew wrapper --gradle-version 8.7

https://docs.gradle.org/8.7/release-notes.html

Motivation and Context

Follow-up test to #554 as complement to dita-ot/dita-ot#4447

How Has This Been Tested?

Results

  • ❌ Java 17 build fails
  • ❌ Java 21 build fails

Note
To test, the wrappers must be updated in both core & docs repos.
See corresponding PR in core repo: dita-ot/dita-ot#4447.

Update Gradle distribution version & regenerate wrapper to pick up recent changes per
https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:upgrading_wrapper

    ./gradlew wrapper --gradle-version 8.7
    ./gradlew wrapper --gradle-version 8.7

https://docs.gradle.org/8.7/release-notes.html

Signed-off-by: Roger Sheen <roger@infotexture.net>
@infotexture infotexture added build Ant/Gradle build scripts & CI/CD issues dependencies Pull requests that update a dependency file labels Apr 4, 2024
@infotexture
Copy link
Member Author

infotexture commented Apr 4, 2024

@jelovirt A few things left to try here:

  • It might make sense to run the same IntelliJ refactoring on the docs Gradle build here in this branch and update the docsrc submodule to point to the result to see if that changes anything.

  • In the docs branches, I re-ran the Gradle wrapper task twice per Gradle recommendations:

    If you want all the wrapper files to be completely up-to-date, you will need to run the wrapper task a second time.

    Might help to do the same in Update Gradle to 8.7 dita-ot#4447.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Ant/Gradle build scripts & CI/CD issues dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant