Skip to content

Commit

Permalink
Remove warning on missing baseUrl, which tsconfig-paths ^4.0.0 doesn'…
Browse files Browse the repository at this point in the history
…t require anymore (#105)

* Remove warning on missing baseUrl, which tsconfig-paths ^4.0.0 doesn't require anymore

* adds reference to PR to the changelog
  • Loading branch information
sverweij committed Jul 11, 2023
1 parent 7534740 commit f8b7fd4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Expand Up @@ -7,6 +7,8 @@ project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased](https://github.com/dividab/tsconfig-paths-webpack-plugin/compare/v4.0.1...master)

- Remove warning on missing baseUrl, which tsconfig-paths ^4.0.0 doesn't require anymore [#105](https://github.com/dividab/tsconfig-paths-webpack-plugin/pull/105).

## [4.0.1](https://github.com/dividab/tsconfig-paths-webpack-plugin/compare/v4.0.0...v4.0.1) - 2023-03-09

- Update tsconfig-paths [#103](https://github.com/dividab/tsconfig-paths-webpack-plugin/pull/103). Thanks to [@rippedspine](https://github.com/rippedspine) for this PR!
Expand Down
10 changes: 0 additions & 10 deletions src/plugin.ts
Expand Up @@ -173,16 +173,6 @@ export class TsconfigPathsPlugin implements ResolvePluginInstance {
return;
}

const { baseUrl } = this;

if (!baseUrl) {
// Nothing to do if there is no baseUrl
this.log.logWarning(
"tsconfig-paths-webpack-plugin: Found no baseUrl in tsconfig.json, not applying tsconfig-paths-webpack-plugin"
);
return;
}

// The file system only exists when the plugin is in the resolve context. This means it's also properly placed in the resolve.plugins array.
// If not, we should warn the user that this plugin should be placed in resolve.plugins and not the plugins array of the root config for example.
// This should hopefully prevent issues like: https://github.com/dividab/tsconfig-paths-webpack-plugin/issues/9
Expand Down

0 comments on commit f8b7fd4

Please sign in to comment.