Added support for absolute paths #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hard to tell what logic you changed with all the whitespace changes. Can you fix those? |
|
Great to hear back from you, as we still live on a separate clone of the official version :) How do you suggest I do it? Clone again and re-apply changes or somehow (how?) transform this PR? |
|
You can try re-commiting with the following commands: git reset --mixed head^
git diff -U0 -w --no-color | git apply --cached --ignore-whitespace --unidiff-zero -
git commit -m 'feat: support absolute paths in `paths` mapping'(Ripped from https://stackoverflow.com/questions/3515597/add-only-non-whitespace-changes) |
|
@jonaskello This is a duplicate of #184. Close it please :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsconfig-paths doesn't follow regular paths resolution (#101)
I can provide a minimal repo, but nevertheless, tsc will not append baseUrl to the path mapping that is absolute
This change is "breaking" change for someone that was using absolute mappings, but as the absolute mappings were not working as expected, it is not highly likely that it will really break anyone's code.
Still, there might be a good idea to make it possible to enable the legacy mode (I can extend the PR) or, even keep the legacy mode as default (since I think the current mode is a bug, I suggest against this idea if possible?)